dialog: Ensure action callback is called with no arguments

Using the callback directly as signal handler means that it will
receive the signal parameters (in this case: the StButton instance
that emits the signal).

This leaks an implementation detail that is harmless in the best
case, but can break dialogs when using bind() on the callback.

Avoid that trap by explicitly calling the callback without arguments.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4139

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1819>

diff --git a/js/ui/dialog.js b/js/ui/dialog.js
index 3e8bfee7d53c5d8723edabea48886a92786512ef..9513a8151a0fbafe6d68c83e1ef4a83c9062ba53 100644 (file)
--- a/js/ui/dialog.js
+++ b/js/ui/dialog.js
@@ -133,7 +133,7 @@ class Dialog extends St.Widget {
             y_expand: true,
             label,
         });
-        button.connect('clicked', action);
+        button.connect('clicked', () => action());
 
         buttonInfo['button'] = button;